Skip to content

Fix proxy parsing #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix proxy parsing #2557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/js/proxified-containers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ proxifiedContainers = {
return false;
}

if (!matches.groups.port) {
matches.groups.port = 1080;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, HTTP(S) have a different default port. Since we're accepting both SOCKS and HTTPS, we should also consider this scenario.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, cleartext HTTP CONNECT and HTTPS are different protocols - are both actually (intended to be) supported? Couldn't find supported protocols actually documented and I was previously of understanding that HTTP but not HTTPS is supported.

}

if (mozillaVpnData && mozillaVpnData.mozProxyEnabled === undefined) {
matches.groups.type = null;
}
Expand Down