Skip to content

Conversation

bakulf
Copy link
Collaborator

@bakulf bakulf commented Oct 1, 2025

Before submitting your pull request

  • I agree to license my code under the MPL 2.0 license.
  • I rebased my work on top of the main branch.
  • I ran npm test and all tests passed.
  • I added test coverages if relevant.

Description

#2802

We are running several research studies with Multi-Account Containers users to learn more about your experiences with the add-on. Interviewees who participate in this first study will receive a $75 Amazon e-giftcard or Paypal transfer in appreciation for their time -- if you’d like to participate, please fill out the research interest form here! Thank you for helping us shape the future of Containers!

Type of change

  • Bug fix
  • New feature
  • Major change (fix or feature that would cause existing functionality to work differently than in the current version)

@dannycolin
Copy link
Collaborator

dannycolin commented Oct 2, 2025

I've tested with different values for containerTabsOpened (lower/higher than 10, hitting 100). Each tests worked as expected. When hitting 100, it showed the survey in priority and only showed the 100 tabs achievement the next time I opened the popup.

@bakulf Should we also account for the scenario where the survey deadline has ended or do you plan to clean up the achievement later on?

@bakulf
Copy link
Collaborator Author

bakulf commented Oct 2, 2025

@bakulf Should we also account for the scenario where the survey deadline has ended or do you plan to clean up the achievement later on?

We will ship a new version as soon as we have enough data from users.

Copy link
Collaborator

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tagging me in the review!

Copy link
Member

@groovecoder groovecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and spot-check looks pretty good. Couple non-blocking question/suggestions.

@bakulf bakulf requested a review from maxxcrawford October 2, 2025 16:22
@groovecoder
Copy link
Member

@bakulf Should we also account for the scenario where the survey deadline has ended or do you plan to clean up the achievement later on?

We will ship a new version as soon as we have enough data from users.

Are you sure about that? IIRC, shipping a new version adds another QA cycle each time. Might be time-consuming just to remove the achievement.

@bakulf
Copy link
Collaborator Author

bakulf commented Oct 2, 2025

Are you sure about that? IIRC, shipping a new version adds another QA cycle each time. Might be time-consuming just to remove the achievement.

well, we will ship version 6.0 changing the version number. I suspect we do not need a deep QA exploration.

@bakulf bakulf merged commit c34c1c1 into main Oct 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants