-
Notifications
You must be signed in to change notification settings - Fork 392
Join our Multi-Account Containers Research Study! 🚀 #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've tested with different values for @bakulf Should we also account for the scenario where the survey deadline has ended or do you plan to clean up the achievement later on? |
We will ship a new version as soon as we have enough data from users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tagging me in the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and spot-check looks pretty good. Couple non-blocking question/suggestions.
Co-authored-by: Maxx Crawford <[email protected]>
Co-authored-by: Maxx Crawford <[email protected]>
Co-authored-by: luke crouch <[email protected]>
Are you sure about that? IIRC, shipping a new version adds another QA cycle each time. Might be time-consuming just to remove the achievement. |
well, we will ship version 6.0 changing the version number. I suspect we do not need a deep QA exploration. |
Before submitting your pull request
npm test
and all tests passed.Description
#2802
We are running several research studies with Multi-Account Containers users to learn more about your experiences with the add-on. Interviewees who participate in this first study will receive a $75 Amazon e-giftcard or Paypal transfer in appreciation for their time -- if you’d like to participate, please fill out the research interest form here! Thank you for helping us shape the future of Containers!
Type of change