This repository was archived by the owner on Jun 29, 2018. It is now read-only.
Wikipedia fix #465
Open
Wikipedia fix #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a really good way to handle this situation -- things are definitely very broken right now. |
|
I take it Mozilla never looks at pull requests for this repo? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #464 so the correct parameters are used in the Wikipedia API call.
I also changed the API call so it only returns the main summary. Often long Wikipedia entries contain table of contents, etc. that look odd in a single block of text. The API 'extract' call lets us just get the main summary at the top of the Wikipedia entry. This means it will be shorter, but probably more meaningful.