adding CI workflow for creating mpv binary and debian `.deb` package #245

ilkermeliksitki · 2024-12-15T10:44:39Z

Currently, the workflow is only running on ubuntu-24.04.

a working mpv binary file is gotten
a debian package is created

During the creation of .deb package, libgnutls-dev couldn't be located and instead the other alternative libgnutls28-dev is used. I am not sure, but maybe we can delete it from the dependencies inside the debian/control file.

Changes to be committed: new file: build_mpv_binary.yml

1- change the name of the workflow 2- change the branch name from main to master 3- add workflow_dispatch Changes to be committed: modified: build_mpv_binary.yml

Changes to be committed: modified: build_mpv_binary.yml

Changes to be committed: renamed: build_mpv_binary.yml -> build_mpv_binary_and_deb_package.yml

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

.github/workflows/build_mpv_binary_and_deb_package.yml

sfan5 · 2024-12-18T14:39:26Z

Can I see the workflow in action somewhere?

add `actions/checkout@v4` Co-authored-by: sfan5 <[email protected]>

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

Co-authored-by: sfan5 <[email protected]>

ilkermeliksitki · 2024-12-18T16:40:27Z

Can I see the workflow in action somewhere?

@sfan5 I guess you should be able to see the logs here.

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

While building the package, by using equivs-build and debian/control file, I got the following error: ``` root@a625b7a1de7c:/mpv-build# equivs-build --full debian/control dpkg-buildpackage: info: source package mpv dpkg-buildpackage: info: source version 1.0 dpkg-buildpackage: info: source distribution unstable dpkg-buildpackage: info: source changed by Kevin Mitchell <[email protected]> dpkg-buildpackage: info: host architecture amd64 dpkg-source --before-build . debian/rules clean dh clean dh: error: Please specify the compatibility level in debian/compat or via Build-Depends: debhelper-compat (= X) make: *** [debian/rules:3: clean] Error 255 dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2 Error in the build process: exit status 2 ``` Based on the error message, I replaced debian/compat with debhelper-compate (= 12) in debian/control file. The existing compat file didn't help to build the package. [Reference](FooBarWidget/debian-packaging-for-the-modern-developer#8 (comment)) Changes to be committed: deleted: compat modified: control

wsldankers · 2024-12-18T20:30:57Z

In general, is it useful to build mpv twice, once separately and once as a package? Building the package already exercises the build scripts. We could drop the first two steps and if we want to run mpv --version we could just install the resulting .deb file.

avih · 2024-12-18T20:38:47Z

Can you please clarify the goal of this PR?

Is it to test that a normal build works, and also the debian packging works?

Or maybe only one of those?

Is it supposed to produce an artifact which debian users can install?

Something else?

ilkermeliksitki · 2024-12-18T20:47:49Z

@avih My aim is to create a workflow that does:

one that just runs the scripts: we should get a functioning mpv binary
one that invokes the debian packaging stuff: we should get a deb package

Here is the original reference given by @sfan5.

This reverts commit a664c8d. Changes to be committed: new file: debian/compat modified: debian/control

1. installation step is deleted during binary building 2. building `.deb` package is moved to `build_debian_package.yml` 3. `build_mpv_binary_and_deb_package.yml` is renamed to `build_debian_package.yml` Changes to be committed: renamed: build_mpv_binary_and_deb_package.yml -> build_debian_package.yml new file: build_mpv_binary.yml

Changes to be committed: modified: build_debian_package.yml

sfan5

Looks good otherwise, where can I see them in action?

.github/workflows/build_debian_package.yml

Changes to be committed: modified: build_debian_package.yml

during the build procedure, the following error was encountered: ``` ... [303/307] Compiling C object libmpv.so.2.5.0.p/video_out_vo_vdpau.c.o [304/307] Linking target libmpv.so.2.5.0 FAILED: libmpv.so.2.5.0 cc -o libmpv.so.2.5.0 libmpv.so.2.5.0.p/audio_aframe.c.o libmpv.so.2.5.0.p/audio_chmap.c.o libmpv.so.2.5.0.p/audio_chmap_avchannel.c.o libmpv.so.2.5.0.p/audio_chmap_sel.c.o libmpv.so.2.5.0.p/audio_decode_ad_lavc.c.o libmpv.so.2.5.0.p/audio_decode_ad_spdif.c.o libmpv.so.2.5.0.p/audio_filter_af_drop.c.o libmpv.so.2.5.0.p/audio_filter_af_format.c.o libmpv.so.2.5.0.p/audio_filter_af_lavcac3enc.c.o libmpv.so.2.5.0.p/audio_filter_af_scaletempo.c.o libmpv.so.2.5.0.p/audio_filter_af_scaletempo2.c.o libmpv.so.2.5.0.p/audio_filter_af_scaletempo2_internals.c.o libmpv.so.2.5.0.p/audio_fmt-conversion.c.o libmpv.so.2.5.0.p/audio_format.c.o libmpv.so.2.5.0.p/audio_out_ao.c.o libmpv.so.2.5.0.p/audio_out_ao_lavc.c.o libmpv.so.2.5.0.p/audio_out_ao_null.c.o libmpv.so.2.5.0.p/audio_out_ao_pcm.c.o libmpv.so.2.5.0.p/audio_out_buffer.c.o libmpv.so.2.5.0.p/common_av_common.c.o libmpv.so.2.5.0.p/common_av_log.c.o ...``` Changes to be committed: modified: build_mpv_binary.yml

This reverts commit b0a19d7.

Changes to be committed: modified: scripts/libass-build

This reverts commit cce2eb6. The trial didn't work. Changes to be committed: modified: scripts/libass-build

Changes to be committed: modified: .github/workflows/build_debian_package.yml

devscripst include the following command to be used in the workflow: - dpkg-buildpackage - mk-build-deps Changes to be committed: modified: .github/workflows/build_debian_package.yml

The workflow gave the following error: mk-build-deps: You must have equivs installed to use this program. Error: Process completed with exit code 127. So equivs package is added as dependency. Changes to be committed: modified: .github/workflows/build_debian_package.yml

Changes to be committed: modified: .github/workflows/build_debian_package.yml

ilkermeliksitki

All feedback are addressed. CI is working. Both building mpv binary, and debian package.

.github/workflows/build_debian_package.yml

kasper93 · 2025-07-06T23:55:25Z

.github/workflows/build_debian_package.yml

+  pull_request:
+    branches:
+      - master
+  workflow_dispatch:


Have you considered adding periodic build?
For example we could build this every day at midnight or every week.

schedule: - cron: "0 0 * * *"

only for this build_debian_package.yml or should I do it for build_mpv_binary.yml as well?

Co-authored-by: Kacper Michajłow <[email protected]>

Changes to be committed: modified: build_debian_package.yml

Changes to be committed: modified: build_mpv_binary.yml

ilkermeliksitki added 11 commits December 9, 2024 00:55

add workflow to build mpv binary

9279413

Changes to be committed: new file: build_mpv_binary.yml

minor fixes

ae4bc75

1- change the name of the workflow 2- change the branch name from main to master 3- add workflow_dispatch Changes to be committed: modified: build_mpv_binary.yml

fix syntax error by adding backslash

9c1955f

Changes to be committed: modified: build_mpv_binary.yml

add the remaining dependencies

b6b4a36

Changes to be committed: modified: build_mpv_binary.yml

delete trailing space

789743b

add sudo to apt clean command

1c5e4ca

Changes to be committed: modified: build_mpv_binary.yml

add install step and change the verifying command

60b578c

Changes to be committed: modified: build_mpv_binary.yml

first attempt to create .deb package for mpv

308a24e

Changes to be committed: modified: build_mpv_binary.yml

add checking mechanism for the existence of .deb file

ade7fad

Changes to be committed: modified: build_mpv_binary.yml

rename the workflow and make it more descriptive

d080a14

Changes to be committed: renamed: build_mpv_binary.yml -> build_mpv_binary_and_deb_package.yml

use apt-get instead of apt in the script

927966d

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

sfan5 reviewed Dec 18, 2024

View reviewed changes

ilkermeliksitki and others added 3 commits December 18, 2024 17:12

Update .github/workflows/build_mpv_binary_and_deb_package.yml

f33b5f7

add `actions/checkout@v4` Co-authored-by: sfan5 <[email protected]>

delete clang

e7126e1

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

simplify the step of checking debian package

3d9f74b

Co-authored-by: sfan5 <[email protected]>

ilkermeliksitki added 7 commits December 18, 2024 18:00

delete python3-pip and python3.12-venv

4cf74d7

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

delete one of the lua versions

fe01d85

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

delete unnecessary encoders

63171fc

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

delete nodejs

8911434

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

delete libcaca

b86ae11

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

add libmp3lame-dev and libx264-dev

87f0c1e

Changes to be committed: modified: build_mpv_binary_and_deb_package.yml

ilkermeliksitki added 3 commits December 18, 2024 21:57

Revert "replace debian/compat with debhelper-compat"

3dda039

This reverts commit a664c8d. Changes to be committed: new file: debian/compat modified: debian/control

check the existence of .deb file

7c362f7

Changes to be committed: modified: build_debian_package.yml

ilkermeliksitki added 2 commits December 18, 2024 23:40

delete enable source repository part

8fe14cc

Changes to be committed: modified: build_debian_package.yml

build-essential package is already installed

6c8b5db

Changes to be committed: modified: build_debian_package.yml

sfan5 self-requested a review February 23, 2025 12:13

sfan5 reviewed Mar 13, 2025

View reviewed changes

.github/workflows/build_debian_package.yml Outdated Show resolved Hide resolved

sfan5 reviewed Mar 13, 2025

View reviewed changes

.github/workflows/build_debian_package.yml Outdated Show resolved Hide resolved

ilkermeliksitki added 4 commits March 13, 2025 22:27

debian package build attempt 1

7fdaf7f

Changes to be committed: modified: build_debian_package.yml

add the run key for verify package creation step

6ea66d2

Changes to be committed: modified: build_debian_package.yml

Revert "add libmpv-dev library"

3f6ce9e

This reverts commit b0a19d7.

kasper93 self-requested a review March 13, 2025 22:43

sfan5 self-requested a review March 18, 2025 22:03

ilkermeliksitki and others added 8 commits April 6, 2025 19:05

Fix trial of linkage error of libass during "rebuild" step

cce2eb6

Changes to be committed: modified: scripts/libass-build

Revert "Fix trial of linkage error of libass during "rebuild" step"

c489fdf

This reverts commit cce2eb6. The trial didn't work. Changes to be committed: modified: scripts/libass-build

Merge branch 'mpv-player:master' into master

0197339

add pwd for debugging purposes

98f76f1

Changes to be committed: modified: .github/workflows/build_debian_package.yml

change update.sh to update

a91fae3

Changes to be committed: modified: .github/workflows/build_debian_package.yml

add devscript to build debian package

471da57

devscripst include the following command to be used in the workflow: - dpkg-buildpackage - mk-build-deps Changes to be committed: modified: .github/workflows/build_debian_package.yml

delete the debuggin pwd line

4a1d8cb

Changes to be committed: modified: .github/workflows/build_debian_package.yml

ilkermeliksitki commented Apr 7, 2025

View reviewed changes

.github/workflows/build_debian_package.yml Outdated Show resolved Hide resolved

ilkermeliksitki requested review from avih and wsldankers April 7, 2025 10:39

kasper93 reviewed Jul 6, 2025

View reviewed changes

ilkermeliksitki and others added 6 commits September 4, 2025 17:03

the number of thread is not assumed

6b2b561

Co-authored-by: Kacper Michajłow <[email protected]>

Update .github/workflows/build_debian_package.yml

5181712

Co-authored-by: Kacper Michajłow <[email protected]>

run the action every day

6de7142

Changes to be committed: modified: build_debian_package.yml

delete apt-get clean

43f72b2

Changes to be committed: modified: build_debian_package.yml

delete apt clear for mpv build

41c51fd

Changes to be committed: modified: build_mpv_binary.yml

use all available cores in rebuild instead of fixed j4

4cc0842

Changes to be committed: modified: build_mpv_binary.yml

ilkermeliksitki requested a review from kasper93 October 14, 2025 08:18

adding CI workflow for creating mpv binary and debian .deb package #245

Are you sure you want to change the base?

adding CI workflow for creating mpv binary and debian .deb package #245

Uh oh!

Conversation

ilkermeliksitki commented Dec 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfan5 commented Dec 18, 2024

Uh oh!

ilkermeliksitki commented Dec 18, 2024

Uh oh!

wsldankers commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avih commented Dec 18, 2024

Uh oh!

ilkermeliksitki commented Dec 18, 2024

Uh oh!

sfan5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ilkermeliksitki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kasper93 Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

ilkermeliksitki Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adding CI workflow for creating mpv binary and debian `.deb` package #245

adding CI workflow for creating mpv binary and debian `.deb` package #245

wsldankers commented Dec 18, 2024 •

edited

Loading