-
Notifications
You must be signed in to change notification settings - Fork 3.2k
console.lua: implement horizontal scroll #16935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
console.lua: implement horizontal scroll #16935
Conversation
|
Download the artifacts for this pull request: Windows |
4291249 to
3f59ac9
Compare
|
#15956 (comment)
|
|
Fixed |
7aee40e to
c5c9ccf
Compare
Bind Shift+LEFT, Shift+RIGHT, Shift+WHEEL_DOWN, Shift+WHEEL_UP, WHEEL_LEFT, WHEEL_RIGHT to scroll the menu horizontally. This lets you see long items that get clipped, like long history entries and key bindings.
Since with the new horizontal scrolling the end of lines can be visible, ensure not to clip lines in the middle of UTF-8 characters to not show mojibake, also adding … to show when items are clipped. Also replace the existing use of ⋯ with …
c5c9ccf to
a96366a
Compare
| { "wheel_down", function() move_history(1, true) end }, | ||
| { "wheel_left", function() end }, | ||
| { "wheel_right", function() end }, | ||
| { "shift+left", function() horizontal_scroll(-25) end }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why with shift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrows without shift move the cursor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do you move the cursor right/left ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever you want?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we never move focus from the text box? strange.

Bind Shift+LEFT, Shift+RIGHT, Shift+WHEEL_DOWN, Shift+WHEEL_UP, WHEEL_LEFT, WHEEL_RIGHT to scroll the menu horizontally.
This lets you see long items that get clipped, like long history entries and key bindings.