add dispose method #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusktr
commented
Mar 25, 2019
| dispose: function () { | ||
|
|
||
| container.removeEventListener( 'click', clickHandler ); | ||
| container.remove(); |
There was a problem hiding this comment.
Do we need container.remove();? Or should we leave that part to the user?
|
Maybe we don't need this at all, if it is true that the handler will be cleaned up if the app is free of references to he Apparently old browsers like IE8 had issues, but Three.js is IE11 and up right? |
|
Well, it doesn't hurt to perform this dispose, just to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.