Improve sparqlEscapeBool #75
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a PR to start a discussion than a real PR.
With using the sparql we have discovered a pretty nasty bug, if you try to convert a value that is not originally boolean (like when you get it from a sparql query it will always default to true, because "false" === true.
I feel like this should be solved because it introduces these kinds of silents bugs. For example we didn't notice the bug until someone complained that the data in the LDES feed was wrong. But I also think the current behaviour is expected so I propose 2 solutions: