[DataGrid] Update cell editable state if editable prop is updated in the column definition
#20147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
scope: data grid
|
Deploy preview: https://deploy-preview-20147--material-ui-x.netlify.app/ Bundle size report
|
arminmeh
changed the title
editable prop is updated in the column definition
cherniavskii
approved these changes
Oct 30, 2025
| // This is to ensure both of the following cases work: | ||
| // - https://github.com/mui/mui-x/issues/19732 | ||
| // - https://github.com/mui/mui-x/issues/20143 | ||
| useGridSelector(apiRef, () => apiRef.current.isCellEditable(cellParams)); |
Member
There was a problem hiding this comment.
Haha, this was my fix initially, but then I thought I could as well use it 🫠
Thanks for fixing it and adding tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20143
Caused by #19898 that fixed #19732
I have added tests emulating demos from
#19732 and #20143
to make sure that both cases work
Related demos with the updated package
https://stackblitz.com/edit/g3buqpzu-tc6suvum?file=package.json
https://stackblitz.com/edit/rdabj1by-cgnlz1xc?file=package.json