Skip to content

fix: support package.json private directive #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: support package.json private directive #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3c880
fix: support package.json private directive
Nytelife26 Apr 11, 2021
554fe96
perf: return early in publish checking
Nytelife26 Apr 11, 2021
b09a2d8
test: fix ci failure due to ignored private
Nytelife26 Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/util/check-publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const getPackageJson = require("./get-package-json")
*/
module.exports = function checkForPublish(context, filePath, targets) {
const packageInfo = getPackageJson(filePath)
if (!packageInfo) {
if (!packageInfo || packageInfo.private) {
return
}

Expand Down
3 changes: 1 addition & 2 deletions tests/fixtures/no-unpublished/1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"private": true,
"name": "test",
"version": "0.0.0",
"dependencies": {
Expand All @@ -8,4 +7,4 @@
"devDependencies": {
"bbb": "0.0.0"
}
}
}
3 changes: 1 addition & 2 deletions tests/fixtures/no-unpublished/2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"private": true,
"name": "test",
"version": "0.0.0",
"dependencies": {
Expand All @@ -8,4 +7,4 @@
"devDependencies": {
"bbb": "0.0.0"
}
}
}
3 changes: 1 addition & 2 deletions tests/fixtures/no-unpublished/3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"private": true,
"name": "test",
"version": "0.0.0",
"files": ["pub"],
Expand All @@ -9,4 +8,4 @@
"devDependencies": {
"bbb": "0.0.0"
}
}
}
1 change: 0 additions & 1 deletion tests/fixtures/no-unpublished/issue126/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"private": true,
"name": "test",
"version": "0.0.0",
"files": [
Expand Down
1 change: 0 additions & 1 deletion tests/fixtures/no-unpublished/negative-in-files/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"private": true,
"name": "test",
"version": "0.0.0",
"files": [
Expand Down