Fixing State Propagation Inconsistencies #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring subscriber updates
wukerplank
reviewed
Sep 11, 2018
|
|
||
| open func dispatch(_ action: Action) { | ||
| dispatchFunction(action) | ||
| guard alwaysDispatchOnMainQueue else { |
There was a problem hiding this comment.
I wish they renamed guard to unless - would make reading code much easier.
|
Awesome, thanks for the changes! Two inputs from my side:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When propagating a state update to all subscribers, it can happen that an action is dispatched as a reaction to said state update. This action is then immediately processed and the state changes it might lead to are then communicated to all subscribers before the prior state changes.
This can lead (and has led) to unexpected (and actually impossible) state changes in the subscribers and this behavior is considered a bug in
ReSwift.Please note that the solution proposed in this PR only works when all actions are dispatched on the main thread, which is a caveat that we are willing to take since it was our default behavior anyway.