chore(iroh): Update n0-watcher
#3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3405/docs/iroh/ Last updated: 2025-07-28T18:01:19Z |
matheus23
force-pushed
the
matheus23/update-n0-watcher
branch
from
98528a7 to
ebfb043
Compare
Frando
approved these changes
Jul 28, 2025
Member
Frando
left a comment
Frando
left a comment
There was a problem hiding this comment.
Diff looks good, nice to see this simplification. Migration guide also read very good and didn't spot anything missing.
I had a quick thought if we could have the Watcher be a future so that you could skip the .initialized but don't think this is possible due to same-crate rules for trait impls on generics. Well, people will get used to the .initialized.
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
## Description This avoids a double-dependency on n0-watcher versions 0.2 and 0.3. I accidentally didn't push this to #3405 ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the
n0-watcherdependency to the new version (that has a lot fewerResults everywhere).n0-watcherdependency net-tools#31net-toolsBreaking Changes
n0-watcherfrom version0.2to0.3.Migration guide for users:
endpoint.node_addr().initialized().await?->endpoint.node_addr().initialized().await(no?needed anymore) and similarly forendpoint.home_relay()and other uses ofWatchers.endpoint.node_addr().get()?->endpoint.node_addr().get()and similarly forendpoint.home_relay()and other uses ofWatchers.&impl Watcherbut you need the current value, then you can't callWatcher::getanymore, as that now takes a&mut selfinstead of&self. You can work around this by.clone()ing to an intermediate watcher:watcher_ref.get()->watcher_ref.clone().get()Change checklist