refactor!: migrate from snafu/n0-snafu to n0-error #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/59/docs/net_tools/ Last updated: 2025-10-31T13:16:46Z |
11 tasks
Frando
changed the title
| ))] | ||
| MessageType::Route => { | ||
| snafu::ensure!(data.len() >= self.body_off, MessageTooShortSnafu); | ||
| n0_error::ensure!(data.len() >= self.body_off, RouteError::MessageTooShort); |
There was a problem hiding this comment.
lets clean this up and actually import ensure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Before next release the
iroh-metricsdep ofportmappershould be bumped toiroh-metrics 0.37after n0-computer/iroh-metrics#56 is merged & releasedMigrates the repo from snafu/n0-snafu to n0-error.
Note: This PR is mostly AI generated after a detailed instruction set on how to do the migration.
I gave the diff a line-by-line review and fixed things up where the AI made mistakes.
Afterwards, I gave the diff another review while adding a few more
from_sourcesand removing manual error mappings.Breaking Changes
meta: n0_error::Metafieldbacktracefields are removed on error enums and structsNotes & open questions
Change checklist