Skip to content

Fix two bugs found in the XPlaneConnect java class (getPOSI and getDREFs methods) #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Fix two bugs found in the XPlaneConnect java class (getPOSI and getDREFs methods) #284

wants to merge 18 commits into from

Conversation

@cpsancha
Copy link

@cpsancha cpsancha commented Aug 9, 2022

Changes:

  • getPOSI: The data returned has changed from XPlane v10 to XPlane v11. In v10, latitude, longitude and elevation were float type (4 bytes) and in v11 they are double (8 bytes). Updated getPOSI function to take it into consideration.
  • getDREFs: Data size (position 6 of the RESP msg) is an integer type, but read as an uint, so when data size is greater than 128, the direct read results into negative size and throws NegativeArraySize exception. Fixed it.
  • Updated the compiled Jar used by the Matlab implementation with the changes hereabove

sanderdatema and others added 15 commits June 28, 2020 09:10
@sanderdatema
Add sendCOMM method for Python 3
f26fe8c
@jason-watkins
Merge pull request nasa#219 from sanderdatema/patch-1
478709d 
Add sendCOMM method for Python 3
re-org and get compiling
5a98144
update issues repo
ebe489c
@jason-watkins
Merge pull request nasa#227 from frizman21/maven-re-org
9c2b3ba 
Maven Folder Structure Re-org
@afefer
Added BCOM and ECOM command support
7904ce6
@afefer
Updated BCOM/ECOM error messages
50686e9
@afefer
Changed structure to std::set; renamed execute
a36e943
@jason-watkins
Merge pull request nasa#234 from afefer/feature/commandStartEnd
f50c055 
Added BCOM/ECOM commands to enable support of beginning/ending X-Plane commands
Fix two bugs found in the XPlaneConnect java class (getPOSI and getDR…
467506b 
…EFs methods)

 - getPOSI: The data returned has changed from XPlane v10 to XPlane v11. In v10, latitude, longitude and elevation were float type (4 bytes) and in v11 they are double (8 bytes). Updated getPOSI function to take it into consideration.
 - getDREFs: Data size (position 6 of the RESP msg) is an integer type, but read as an uint, so when data size is greater than 128, the direct read results into negative size and throws NegativeArraySize exception. Fixed it.
Update compiled jar file used by Matlab after the changes in the Java…
c0ae25a 
… classes
Fix bug related with the getDREFs method --> DataRef data size is 2 b…
bd8171c 
…yte length instead of 1
@Calebsakhtar
Add a call of WSACleanup() to closeUDP()
2b03171
@Calebsakhtar
Call WSACleanup in the destructor of UDPSocket
fee6b3f
@jason-watkins
Merge pull request nasa#291 from Calebsakhtar/CAM-cleanup-socket-cpp
44f8b39 
Bugfix: Add a cleanup command to closeUDP() (C/C++)
@GPGD
Copy link

GPGD commented Jan 23, 2023

Many thanks for this, fixed issues I was having

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cpsancha @GPGD @sanderdatema @jason-watkins @afefer @Calebsakhtar