-
Notifications
You must be signed in to change notification settings - Fork 43
Unify all FPP tools #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unify all FPP tools #799
Conversation
Ah good catch, |
I'm marking this PR as fprime-fpp-tandem, since this represents a significant change to how we publish the FPP tools to F Prime. Before merging this PR, let's make sure we have worked out the details of how F Prime will use this version of the tools. |
How about if we don't add it in, and just consolidate #770 with this PR? Otherwise we'll need to add it in now and then remove it later. |
Alternatively we could do #770 and then merge this PR. I'd rather not add |
I did a combo of both, I opened a PR that removes To-XML entirely against this PR. |
Purge FPP-to-XML
This PR creates a single FPP entrypoint that wraps our tools. It passes a single argument to a
scopt
parser to allow parsing the FPP command. The top level entrypoint select the tool to run and then passes off the rest of the arguments to that tools entrypoint.The main tool also includes a nice
--help
message to guide users (I copied the--help
style of Docker and git):Closes #798
fpp-check
that callfpp check
.