Skip to content

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Oct 17, 2025

Closes #8184

NEEDS CHERRY-PICK TO GOLD

Describe your changes:

  • Removes superfluous stringification of object keys in query. This was causing an HTTP error 400 to be returned from Couch
  • Adds a test to verify that Couch uses the search index and that it returns an HTTP success .

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

* Reference telemetry map as a Map, not associative array

* Only normalize once

* Another cheeky createNormalizedDatum

* Fix unit tests that were broken by removal of createNormalizedDatum

* Fixed failing test
@akhenry akhenry force-pushed the 8184-couch-requests-views-failing branch from 20fbf7c to 3550046 Compare October 17, 2025 23:18
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.20%. Comparing base (896d77a) to head (19749d5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8185   +/-   ##
=======================================
  Coverage   57.20%   57.20%           
=======================================
  Files         704      704           
  Lines       28283    28282    -1     
  Branches     2770     2770           
=======================================
+ Hits        16179    16180    +1     
+ Misses      11760    11758    -2     
  Partials      344      344           
Flag Coverage Δ
e2e-ci 63.16% <0.00%> (+<0.01%) ⬆️
e2e-full 42.38% <100.00%> (-0.02%) ⬇️
unit 48.35% <0.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
...c/plugins/persistence/couch/CouchObjectProvider.js 92.71% <100.00%> (+1.93%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896d77a...19749d5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2025
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2025
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Oct 17, 2025
@akhenry akhenry added this to the Release 4.2.0 milestone Oct 17, 2025
@akhenry akhenry requested a review from jvigliotta October 18, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Couch Requests that utilize views are failing

1 participant