Skip to content

Use popOne in JS API routed request workers #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

Use popOne in JS API routed request workers #6355

merged 2 commits into from
Jan 9, 2025

Conversation

@neilalexander
Copy link
Member

@neilalexander neilalexander commented Jan 9, 2025

This updates the JS API workers to use popOne, so that if the queue stacks up at all, the recovery is fairer across workers, rather than single workers stealing the entire queue.

This was extracted from #6342.

Signed-off-by: Neil Twigg [email protected]

@neilalexander neilalexander requested a review from a team as a code owner January 9, 2025 16:03
derekcollison
derekcollison reviewed Jan 9, 2025
View reviewed changes
@derekcollison derekcollison self-requested a review January 9, 2025 17:14
derekcollison
derekcollison approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander
Copy link
Member Author

neilalexander commented Jan 9, 2025

Rebased to include a race condition fix.

@derekcollison
Copy link
Member

derekcollison commented Jan 9, 2025

I am just waiting on green run to merge.

@derekcollison derekcollison self-requested a review January 9, 2025 17:19
derekcollison
derekcollison approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 1dcd873 into main Jan 9, 2025
5 checks passed
@derekcollison derekcollison deleted the neil/jsapipopone branch January 9, 2025 18:31
@wallyqs wallyqs mentioned this pull request Jan 9, 2025
Merged
wallyqs added a commit that referenced this pull request Jan 9, 2025
@wallyqs
Cherry-picks for 2.10.25-RC.1 (#6345)
339d1b3 
#### Dependencies
- #6323
- #6324

####  Leafnode
- #6291

#### JetStream
- #6226
- #6235
- #6277
- #6279
- #6283
- #6289
- #6316
- #6317
- #6325
- #6326
- #6335
- #6338
- #6341
- #6344
- #6150
- #6351
- #6355

#### Tests
- #6278
- #6297
- #6300
- #6343
- #6329
- #6330
- #6331
- #6332
- #6334
- #6356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neilalexander @derekcollison