Skip to content

Conversation

praveenmatanam
Copy link
Contributor

@praveenmatanam praveenmatanam commented Sep 25, 2025

Related Issue(s)

Proposed Changes

Cisco IOS-XR Version

24.4.2

Checklist

Test, validate and ensure pre-commit is run before submitting PR

  • Latest commit is rebased from main/master with merge conflicts resolved
  • All pre-commit hooks passed

@rwcrowe rwcrowe self-requested a review September 25, 2025 17:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We are not planning on supporting defaults for list items at this point. You can simplify line 4.
for ospf_process in try(local.device_config[device.name].router_ospf, []) : {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Your defaults fallback have underscores instead of periods. Please correct to work.
local.defaults.iosxr.configuration.router_ospf.process_name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@praveenmatanam praveenmatanam requested a review from rwcrowe October 1, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants