Skip to content

[ENHANCEMENT] Add support for prefix_set #142 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ENHANCEMENT] Add support for prefix_set #142 #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ module "iosxr" {
| [iosxr_logging_source_interface.logging_source_interface](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/logging_source_interface) | resource |
| [iosxr_mpls_oam.mpls_oam](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/mpls_oam) | resource |
| [iosxr_ntp.ntp](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/ntp) | resource |
| [iosxr_prefix_set.prefix_set](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/prefix_set) | resource |
| [iosxr_router_static_ipv4_unicast.router_static_ipv4_unicast](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/router_static_ipv4_unicast) | resource |
| [iosxr_segment_routing.segment_routing](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/segment_routing) | resource |
| [iosxr_service_timestamps.service_timestamps](https://registry.terraform.io/providers/CiscoDevNet/iosxr/latest/docs/resources/service_timestamps) | resource |
Expand Down
22 changes: 22 additions & 0 deletions iosxr_prefix_set.tf
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The defaults fallback have underscores instead of spaces. Can you correct.
    local.defaults.iosxr.configuration.prefix_set.set_name
  • Line 4 - We are only supporting defaults for non-lists. You can remove the defaults check.
    for prefix_set in try(local.device_config[device.name].prefix_set, []) : {

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
locals {
device_prefix_sets = flatten([
for device in local.devices : [
for prefix_set in try(local.device_config[device.name].prefix_set, local.defaults.iosxr.configuration.prefix_set, []) : {
device_name = device.name
set_name = try(prefix_set.set_name, local.defaults.iosxr.configuration.prefix_set_set_name, null)
rpl = try(prefix_set.rpl, local.defaults.iosxr.configuration.prefix_set_rpl, null)
key = try("${device.name}-${prefix_set.set_name}", null)
}
if try(prefix_set.set_name, local.defaults.iosxr.configuration.prefix_set_set_name, null) != null &&
try(prefix_set.rpl, local.defaults.iosxr.configuration.prefix_set_rpl, null) != null
]
])
}

resource "iosxr_prefix_set" "prefix_set" {
for_each = { for prefix_set in local.device_prefix_sets : prefix_set.key => prefix_set }

device = each.value.device_name
set_name = each.value.set_name
rpl = each.value.rpl
}