[ENHANCEMENT] Add support for policy_map_qos #152 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwcrowe
requested changes
Oct 1, 2025
There was a problem hiding this comment.
- Line 4 - You only need to iterate on one item (policy_map_name).
- Line 7 - Please add the resource name to the key.
"${device.name}-policy_map_qos-${policy_map_name}" - Please check all your default fallbacks. They have underscores instead of periods.
policy_map_qos_descriptionshould bepolicy_map_qos.description - You are missing alot of attributes in the schema (after queue limits). Please include all attributes, not just the example usage ones.
- Line 21 not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
Cisco IOS-XR Version
24.4.2
Checklist
Test, validate and ensure pre-commit is run before submitting PR