-
-
Notifications
You must be signed in to change notification settings - Fork 910
[client] Fix netstack upstream dns and add wasm debug methods #4648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes netstack upstream DNS functionality and adds debug methods to the WASM client. The main focus is refactoring status-related functionality and improving DNS handling in netstack environments.
Key Changes:
- Refactors status methods to use method receivers instead of standalone functions
- Enhances netstack DNS support with upstream resolution through tunnel
- Adds comprehensive debug methods (ping, status reporting, log level control) to WASM client
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| client/wasm/cmd/main.go | Adds extensive debug methods including ping, status reporting, and log level management |
| client/status/status.go | Refactors standalone functions to methods on OutputOverview struct |
| client/internal/dns/upstream*.go | Updates DNS resolvers to use netstack when available for tunnel routing |
| client/internal/peer/status.go | Moves protobuf conversion logic and adds event history to FullStatus |
| client/server/server.go | Removes duplicate protobuf conversion code, delegates to peer status |
| client/embed/embed.go | Adds status, sync response, and log level management methods |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|



Describe your changes
jsonly)ParseToJSON()→JSON(),ParseToYAML()→YAML(),ParseGeneralSummary()→GeneralSummary(),ParseToFullDetailSummary()→FullDetailSummary()toProtoFullStatus()→FullStatus.ToProto()methodFullStatus(removeGetEventsRPC)Status(),GetLatestSyncResponse(),SetLogLevel()ping(hostname)pingTCP(hostname, port)status()statusDetail()statusSummary()setLogLevel(level)getSyncResponse()Start()to trackconnectinstead ofcancelfor state checkingStop()to cancel context and clean up properlyIssue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__