Skip to content

Conversation

justin-tay
Copy link
Contributor

This fixes idn-hostname format to recognise all the label separator characters in https://datatracker.ietf.org/doc/html/rfc3490#section-3.1.

This also updates the JSON Schema Test Suite to ensure that the tests all pass particularly the tests introduced for this

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (48ca3c2) to head (33110c8).
⚠️ Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
...com/networknt/schema/format/IdnHostnameFormat.java 0.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1191      +/-   ##
============================================
- Coverage     78.90%   78.43%   -0.47%     
- Complexity     1965     2087     +122     
============================================
  Files           172      201      +29     
  Lines          6352     6882     +530     
  Branches       1255     1260       +5     
============================================
+ Hits           5012     5398     +386     
- Misses          867     1014     +147     
+ Partials        473      470       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit 61fa3a5 into networknt:master Sep 13, 2025
4 checks passed
@justin-tay justin-tay deleted the fix-idnhostname branch September 14, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants