Skip to content

Fixes for #479, #480, #481 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 71 commits into
base: opensourceleg-rs
Choose a base branch
from
Open

Fixes for #479, #480, #481 #486

wants to merge 71 commits into from

Conversation

unshrawal
Copy link
Contributor

#481 - This PR flattens the current JSON schema so that all values are logged under the "attributes" key instead of grouping values differently for variables and functions.

#480 - This PR fixes the current use of a hardcoded "variables.log" string, and instead uses the user-given string for the log file and uses this name for the JSON data file.

#479 - Currently, we set up the user-configured file at initialization. This is a problem in the open-source leg library, since we initialize a global logger, and the user might change their logging configuration, which can lead to empty and unused files. This PR fixes this by lazily creating the files.

unshrawal added 30 commits June 20, 2025 18:40
@unshrawal
Conditionally add layers
e17e348
@unshrawal
speedup
cbf0b74
@unshrawal
Show params
ed33307
@unshrawal
Refactor
06411b9
@unshrawal
Fix serialization bottleneck
574049e
@unshrawal
Accommodate class arguments
f47a0f6
@unshrawal
optimize downcasts
c18fd79
@unshrawal
Remove label
2fb2311
@unshrawal
Use writeln instead of tracing for variable tracking
8b22705
@unshrawal
Put var file & log file in same dir
5b463d7
@unshrawal
Add file rotator
76eaf2a
@unshrawal
Remove unused imports
0ec8f51
@unshrawal
Stub file + overwrite warning
52dc200
@unshrawal
Configurable log level for console & log layer
20be94b
@unshrawal
Clear directory and fix stubs
0095e1c
@unshrawal
Use buffered writer & flush at python exit
9587e3a
@unshrawal
Refactor + Fix top level API
8b5cc49
@unshrawal
Don't flush in maybe_rotate
3d3c47b
@unshrawal
Setup user API for zenoh logger
f4d672a
@unshrawal
Update stub
d750562
@unshrawal
benchmark the loggers
e01a742
@unshrawal
fix readme
bbc930c
@unshrawal
Remote pycache
1802737
@unshrawal
Update README
116803c
@unshrawal
Update README
89a00dd
@unshrawal
Fix warnings
d1361d9
@unshrawal
Fix dependency issues
1def61a
@unshrawal
Add timestamp to JSON variable logfile
ca2ce34
@unshrawal
Add nonblocking writer from tracing for records
6dadf7a
@unshrawal
Remove unused imports
147ab3b
unshrawal and others added 30 commits July 14, 2025 22:05
@unshrawal
Remove expensive ChronoLocal syscall 2x improvement
2489847
@unshrawal
Merge branch 'master' of https://github.com/unshrawal/logger
1010d40
@unshrawal
Update README.md
0eb1613
@unshrawal
Update README.md
989b384
@unshrawal
Fix Zenoh for ROS applications
c7059bf
@unshrawal
Generalize zenoh config
608fe68
@unshrawal
Update readme
1742fc5
@unshrawal
Add 'opensourceleg/logging/observe/' from commit '1742fc527d1212cf00e…
a728004 
…fde8a811a95bde77e21c3'

git-subtree-dir: opensourceleg/logging/observe
git-subtree-mainline: 05cd2e4
git-subtree-split: 1742fc5
@unshrawal
Add observe as a subtree
52bbe2d
@unshrawal
Fix tutorials
2cfccd4
@unshrawal
fix logger implementation in tutorials and controllers
74221e2
@unshrawal
Change from old logger to new
ebd6bc7
@unshrawal
Fixed all usages of old logger in OSL
28ec25d
@unshrawal
RECONFIGURATION WORKS!
5ad0f80
@unshrawal
Update stub file
b66c80a
@unshrawal
Merge commit 'b66c80a6686bf37c2f5d5ab24451e00422161257' into opensour…
ee5d7cc 
…celeg-rs
@unshrawal
Make logging configurable at runtime
019b24a
@unshrawal
Complete integration of rust logger with OSL
10e7075
@unshrawal
Add benching scripts
6b92b9d
@unshrawal
replace observable with opensourceleg_rs
3f8f605
@unshrawal
Fix old logger usage in OSL
fddaf2c
@unshrawal
Setup global logger
aa07c73
@unshrawal
Fix global logger issues
b0ce90e
@unshrawal
Senthur fixes
0a45620
@unshrawal
Senthur suggestions
6343563
@senthurayyappan
Merge pull request #469 from unshrawal/opensourceleg-rs
c80365b 
Rust Logger OSL Merge
@unshrawal
Change record to use our rotator instead of the generic one
6c50ae7
@unshrawal
Change the rotator to lazily create the file upon first write.
dda0045
@unshrawal
fix: Use given log filename with .csv or .json extension for data log…
0326a67 
…ging

Fixes #480

Also fixes a bug inside update_log_configuration which only moves the log file, and not the .json file.
@unshrawal
fix: Merge functions and variables categories in data logs
c42735b 
Fixes #481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unshrawal @senthurayyappan