Skip to content

Conversation

@niksirbi
Copy link
Member

@niksirbi niksirbi commented Sep 23, 2025

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Chang in deployment of multi-version docs

Why is this PR needed?

We currently use a messy workflow for publishing docs for multiple versions of NeuroBlueprint, as well as a "dev" version.

@animeshsasan has kindly turned that prototype into a reusable action, see neuroinformatics-unit/actions#93

What does this PR do?
Switches from our messy prototype to using the re-usable action, called deploy_sphinx_docs_multiversion.

References

neuroinformatics-unit/actions#91
neuroinformatics-unit/actions#93
neuroinformatics-unit/movement#668

How has this PR been tested?

During neuroinformatics-unit/actions#93 @animeshsasan tested this new action on several forks. See that PR for details.

Is this a breaking change?

No. In theory, this should all work out fine for the next release and previous versions should be preserved.

Does this PR require an update to the documentation?

No. I've updated the comment at the top of the yaml workflow to reflect the new behaviour.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@niksirbi niksirbi marked this pull request as ready for review September 23, 2025 15:38
Copy link
Member

@JoeZiminski JoeZiminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoeZiminski JoeZiminski merged commit e09b319 into main Sep 23, 2025
3 checks passed
@JoeZiminski JoeZiminski deleted the use-action-for-multiversion-docs branch September 23, 2025 15:41
@niksirbi niksirbi mentioned this pull request Sep 23, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants