-
Notifications
You must be signed in to change notification settings - Fork 1
Improve homepage of photon-mosaic website #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the link to CASCADE can be the one to the original repo
Sorry I was looking at the outdated commtit! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, just a few small comments.
Co-authored-by: Adam Tyson <[email protected]>
Co-authored-by: Adam Tyson <[email protected]>
Co-authored-by: Adam Tyson <[email protected]>
Co-authored-by: Adam Tyson <[email protected]>
|
@adamltyson thanks for the comments. I've edited the illustration and expanded the explanations in the body. Let me know if it reads better to you now. I'll merge then. |
|
Looks good, only two final comments:
|
|
I like the colon in the bullet point 😅 |
It doesn't make sense though! |
|
@adamltyson I've made the suggested edits on formatting and contributing guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. LGTM!
|
Random point - if the neuropil subtraction from the allenSDK is adopted (as per the "Planned additions" section), it will need to be vendored as that package isn't maintained anymore. |
|
@adamltyson yes correct that's the plan! |
Description
What is this PR
Why is this PR needed?
Add logo, illustrations, improve description in the readme and homepage.
Note that after merging this PR documentation still needs major improvements. This is meant to be only for the homepage.
What does this PR do?
Adds figures, edits
docs/source/files andREADME.mdReferences
#27
How has this PR been tested?
Local build of website
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: