Update Shorten Posts extension #1972
Open
+139
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't relevant anymore with NPF
beccasafan
force-pushed
the
fix/shorten-posts
branch
from
727442a to
92fc782
Compare
|
|
||
| run: function() { | ||
|
|
||
| this.running = true; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
AprilSylph
requested changes
Sep 10, 2020
| XKit.extensions.shorten_posts.cpanel_check_height(); | ||
|
|
||
| if ($(".posts .post").length > 0) { | ||
| if ($("[data-id], .posts .post").length > 0) { |
There was a problem hiding this comment.
this check should be removed entirely in case the user hard-loads onto a page without posts and then soft-loads onto a page with posts
|
|
||
| $obj.addClass("xkit-shorten-posts-shortened"); | ||
|
|
||
| $article.append("<div class=\"xkit-shorten-posts-embiggen xkit-shorten-posts-embiggen-for-post-" + post_id + "\" data-post-id=\"" + post_id + "\" data-old-height=\"" + height + "\">This post has been shortened. Click here to show the full post</div>"); |
There was a problem hiding this comment.
all these escapes and string concatenation is a little rough, could this be a template string instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for react, remove options that aren't relevant anymore with NPF, add a threshold preference as discussed in Discord.