-
Notifications
You must be signed in to change notification settings - Fork 310
feat(config): Span event config controlled through env vars #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1096 +/- ##
===========================================
+ Coverage 78.09% 78.13% +0.04%
===========================================
Files 159 159
Lines 15854 15913 +59
===========================================
+ Hits 12381 12434 +53
- Misses 3060 3065 +5
- Partials 413 414 +1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
assignBool(&cfg.CustomInsightsEvents.CustomAttributesEnabled, "NEW_RELIC_APPLICATION_LOGGING_FORWARDING_CUSTOM_ATTRIBUTES_ENABLED") | ||
|
||
// Span Event Env Variables | ||
assignBool(&cfg.SpanEvents.Enabled, "NEW_RELIC_SPAN_EVENTS_ENABLED") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirackara I added in this line to allow for control for enabling span events through env vars. Should I add a function for this as well?
ff861ca
to
1cd6e7b
Compare
This reverts commit 6e3cff6.
…s logic to config options
Links
Example of python agent environment variables
Example of python agent setting Span Event env vars
Details
Issue
The Go Agent does not control sending spans through environment variables
Goals
Allow the Go Agent to control sending spans through environment variables
Implementation
MaxSamplesStored
field toConfig.SpanEvents
Config.SpanEvents.MaxSamplesStored
andConfig.SpanEvents.Enabled
via environment variablesHow to test
In progress...