-
Notifications
You must be signed in to change notification settings - Fork 156
Period based adaptive sampler #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kanderson250
wants to merge
17
commits into
main
Choose a base branch
from
period-based-adaptive-sampler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d remove AdaptiveSampling class
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
============================================
- Coverage 71.15% 70.26% -0.89%
+ Complexity 10746 10046 -700
============================================
Files 849 850 +1
Lines 42594 40904 -1690
Branches 6634 6191 -443
============================================
- Hits 30307 28743 -1564
+ Misses 9454 9359 -95
+ Partials 2833 2802 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…om NR header when sampled decision unknown
newrelic-agent/src/main/java/com/newrelic/agent/tracing/samplers/AdaptiveSampler.java
Show resolved
Hide resolved
…c numbers/strings with constants
jbedell-newrelic
previously approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2485
This PR decouples our adaptive sampler from the harvest cycle, in an effort to support upcoming initiatives for core tracing and otel style sampling algorithms.
What's Changed
Previously, our adaptive sampler was tied to the transaction reservoir (and therefore, the harvest cycle) to perform its math. This PR:
Adds/Updates
Removes
Configuration
The AdaptiveSampler can be configured with the
adaptive_sampling_target
setting.Relevant Specifications
Adaptive Sampler specification: https://source.datanerd.us/agents/agent-specs/blob/main/distributed_tracing/Distributed-Tracing.md#adaptive-sampler
Remote Parent Sampled Flag specification: https://source.datanerd.us/agents/agent-specs/blob/main/distributed_tracing/Distributed-Tracing.md#determining-whether-the-remote-parent-was-sampled
Testing
Unit tests have been added for the adaptive sampler, Transaction class, and DistributedTraceServiceImpl to support these changes. Cross agent tests have been added. Existing tests have been updated.