Skip to content

Conversation

hmstepanek
Copy link
Contributor

Overview

This adds support for the concept of partial granularity distributed traces. There are 3 types:

  • reduced
  • essential
  • compact

@hmstepanek hmstepanek requested a review from a team as a code owner October 2, 2025 17:59
Copy link

github-actions bot commented Oct 2, 2025

MegaLinter analysis: Error

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 1.02s
✅ MARKDOWN markdownlint 7 0 0 0 1.38s
❌ PYTHON ruff 946 1 1 0 1.17s
⚠️ PYTHON ruff-format 946 10 1 0 0.33s
✅ YAML prettier 15 0 0 0 1.48s
✅ YAML v8r 15 0 0 5.97s
✅ YAML yamllint 15 0 0 0.64s

Detailed Issues

❌ PYTHON / ruff - 1 error
::error title=Ruff (invalid-syntax),file=tests/agent_features/test_distributed_tracing.py,line=488,col=27,endLine=488,endColumn=28::tests/agent_features/test_distributed_tracing.py:488:27: invalid-syntax: Expected ',', found ':'
::error title=Ruff (invalid-syntax),file=tests/agent_features/test_distributed_tracing.py,line=489,col=13,endLine=489,endColumn=14::tests/agent_features/test_distributed_tracing.py:489:13: invalid-syntax: Expected ':', found '}'
⚠️ PYTHON / ruff-format - 1 error
error: Failed to parse tests/agent_features/test_distributed_tracing.py:488:27: Expected ',', found ':'
10 files reformatted, 931 files left unchanged

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 55.76923% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.13%. Comparing base (92698ac) to head (27573b4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/core/node_mixin.py 40.81% 25 Missing and 4 partials ⚠️
newrelic/api/transaction.py 60.00% 18 Missing and 4 partials ⚠️
newrelic/config.py 0.00% 8 Missing ⚠️
newrelic/core/external_node.py 20.00% 4 Missing ⚠️
newrelic/core/config.py 90.00% 0 Missing and 2 partials ⚠️
newrelic/core/data_collector.py 50.00% 1 Missing and 1 partial ⚠️
newrelic/core/loop_node.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1532       +/-   ##
===========================================
- Coverage   81.61%   37.13%   -44.48%     
===========================================
  Files         207      207               
  Lines       23909    24002       +93     
  Branches     3789     3809       +20     
===========================================
- Hits        19514     8914    -10600     
- Misses       3123    14187    +11064     
+ Partials     1272      901      -371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmstepanek hmstepanek force-pushed the partial-granularity-type-support branch from 831fa32 to ca79220 Compare October 7, 2025 00:07
@hmstepanek hmstepanek marked this pull request as draft October 7, 2025 00:08
@hmstepanek hmstepanek force-pushed the partial-granularity-type-support branch 2 times, most recently from 4cf77da to 87fa35c Compare October 7, 2025 01:05
* Reorder inheritance on span nodes

Core tracing will be adding a bunch of logic to the span_event method which is called
via super on inheriting classes before those inheriting classes add additional
attributes. In order for the core tracing logic to work correctly, this inheritance
call order has to be reversed; the inheriting classes must first add the attributes
and THEN call super.

* Remove *args, **kwargs

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: hmstepanek <[email protected]>
@hmstepanek hmstepanek force-pushed the partial-granularity-type-support branch 2 times, most recently from fd03498 to 2dfb588 Compare October 10, 2025 20:18
@hmstepanek hmstepanek force-pushed the partial-granularity-type-support branch from d3cf8a6 to 64e58b4 Compare October 10, 2025 21:16
@hmstepanek hmstepanek force-pushed the partial-granularity-type-support branch from 303468c to 27573b4 Compare October 10, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants