-
Notifications
You must be signed in to change notification settings - Fork 127
Add support for partial granularity type #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hmstepanek
wants to merge
3
commits into
main
Choose a base branch
from
partial-granularity-type-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌MegaLinter analysis: Error
Detailed Issues❌ PYTHON / ruff - 1 error
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1532 +/- ##
===========================================
- Coverage 81.61% 37.13% -44.48%
===========================================
Files 207 207
Lines 23909 24002 +93
Branches 3789 3809 +20
===========================================
- Hits 19514 8914 -10600
- Misses 3123 14187 +11064
+ Partials 1272 901 -371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
831fa32
to
ca79220
Compare
4cf77da
to
87fa35c
Compare
* Reorder inheritance on span nodes Core tracing will be adding a bunch of logic to the span_event method which is called via super on inheriting classes before those inheriting classes add additional attributes. In order for the core tracing logic to work correctly, this inheritance call order has to be reversed; the inheriting classes must first add the attributes and THEN call super. * Remove *args, **kwargs * [MegaLinter] Apply linters fixes --------- Co-authored-by: hmstepanek <[email protected]>
fd03498
to
2dfb588
Compare
d3cf8a6
to
64e58b4
Compare
303468c
to
27573b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds support for the concept of partial granularity distributed traces. There are 3 types: