Skip to content

Conversation

hmstepanek
Copy link
Contributor

Overview

Core tracing will be adding a bunch of logic to the span_event method which is called via super on inheriting classes before those inheriting classes add additional attributes. In order for the core tracing logic to work correctly, this inheritance call order has to be reversed; the inheriting classes must first add the attributes and THEN call super.

@hmstepanek hmstepanek requested a review from a team as a code owner October 7, 2025 00:25
Copy link

github-actions bot commented Oct 7, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.96s
✅ MARKDOWN markdownlint 7 0 0 0 1.35s
✅ PYTHON ruff 946 5 0 0 0.97s
✅ PYTHON ruff-format 946 5 0 0 0.34s
✅ YAML prettier 15 0 0 0 1.42s
✅ YAML v8r 15 0 0 4.78s
✅ YAML yamllint 15 0 0 0.65s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.51%. Comparing base (27f357c) to head (59c2207).

Files with missing lines Patch % Lines
newrelic/core/loop_node.py 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (27f357c) and HEAD (59c2207). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (27f357c) HEAD (59c2207)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1539       +/-   ##
===========================================
- Coverage   81.72%   71.51%   -10.21%     
===========================================
  Files         207      207               
  Lines       23909    23904        -5     
  Branches     3789     3789               
===========================================
- Hits        19540    17096     -2444     
- Misses       3098     5274     +2176     
- Partials     1271     1534      +263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Core tracing will be adding a bunch of logic to the span_event method which is called
via super on inheriting classes before those inheriting classes add additional
attributes. In order for the core tracing logic to work correctly, this inheritance
call order has to be reversed; the inheriting classes must first add the attributes
and THEN call super.
@hmstepanek hmstepanek force-pushed the reorder-node-super-calls branch from 01341fa to 2fcf966 Compare October 7, 2025 00:34
@lrafeei
Copy link
Contributor

lrafeei commented Oct 7, 2025

This is more of a general question: Originally, span_event() in each node class had "*args, **kwargs" as the signature but now they have the keyword arguments and the *args, **kwargs in their signature. All of these keyword arguments are the same and there is not a node class that uses something different/extra, so do we even need the "*args, **kwargs" part of the signature anymore?

@lrafeei lrafeei self-assigned this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-failing Tests failing in CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants