[Spring MVC] 민지인 미션제출합니다 #503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanxiu
reviewed
Oct 4, 2025
|
|
||
| @GetMapping("/reservation") | ||
| public String reservation(){ | ||
| return "/reservation.html"; |
There was a problem hiding this comment.
뷰 이름만 사용하셔도 됩니다! return "reservation" 하셔도 자동으로 templates/reservation.html을 찾아서 렌더링할 거예요.
There was a problem hiding this comment.
그리고 지금 Model 에 데이터가 없어요. 리스트를 담아서 전달해야 합니다~
| } | ||
|
|
||
| @GetMapping("/reservations") | ||
| public ResponseEntity<List<Reservation>> reservations(){ |
There was a problem hiding this comment.
ResponseEntity 를 사용하셨군요! 좋아요. 하지만 우리 학습 키워드 중 하나가 @ResponseBody 인 만큼 이것을 사용해보는 건 어떨까요?
수정 후 푸시 완료했습니다! 감사합니다. |
juanxiu
reviewed
Oct 6, 2025
| import java.time.LocalTime; | ||
|
|
||
| public class Reservation { | ||
| public Long id; |
There was a problem hiding this comment.
제가 놓쳤네요! 필드의 접근 지정자를 무엇으로 설정해야 할까요? public vs private 에 대해 공부해보면 좋을 것 같습니다.
|
dto 멤버변수 접근지정자 수정 후 푸시했습니다. 캡슐화를 위해 멤버변수를 private으로 설정했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1단계 - 홈 화면
2단계 - 예약 조회
(실수로 단계별 commit을 나누지 못했는데, 다음주차부터는 나누어 진행하겠습니다! 번거로이 해드려서 죄송합니다.)