Skip to content

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 20, 2025

Summary

If the current request does not have permissions for the filesystem we must not try to setup the filesystem.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Sep 20, 2025
@susnux susnux requested a review from a team as a code owner September 20, 2025 10:58
@susnux susnux removed the request for review from a team September 20, 2025 10:58
@susnux susnux added the bug label Sep 20, 2025
@susnux
Copy link
Contributor Author

susnux commented Sep 20, 2025

/backport to stable32

@susnux
Copy link
Contributor Author

susnux commented Sep 20, 2025

/backport to stable31

@susnux susnux requested review from CarlSchwan and come-nc and removed request for sorbaugh September 20, 2025 10:58
@susnux susnux force-pushed the fix/encryption-lockdown branch from 1c8731b to cf0f6f2 Compare September 20, 2025 15:43
If the current request does not have permissions for the filesystem we
must not try to setup the filesystem.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/encryption-lockdown branch from cf0f6f2 to 7cc3c1f Compare September 20, 2025 20:23
@susnux susnux merged commit 9c0e390 into master Sep 22, 2025
217 of 221 checks passed
@susnux susnux deleted the fix/encryption-lockdown branch September 22, 2025 09:44
Copy link

backportbot bot commented Sep 22, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/55236/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7cc3c1f6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/55236/stable31

Error: Failed to push branch backport/55236/stable31: remote: {"auth_status":"auth_error","body":"Invalid username or token. Password authentication is not supported for Git operations."}
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@lxp
Copy link

lxp commented Sep 22, 2025

Thank you for taking the time to fix this issue!
I manually applied the fix to Nextcloud 31.0.9 and it works fine.
There seems to be a problem with the backportbot. Should I manually open a PR for backporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CalDAV/CardDAV sync fails with app password when file access is disabled – results in HTTP 503
6 participants