[stable32] fix(ocm-invites): add route to invite accept dialog #55239
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Maxence Lange <[email protected]>
backportbot
bot
requested review from
AndyScherzinger,
provokateurin,
icewind1991,
salmart-dev,
come-nc and
ArtificialOwl
and removed request for
a team
|
@ArtificialOwl merge as is? |
come-nc
reviewed
Sep 22, 2025
| ), | ||
| new Entry(self::LASTCRON_TIMESTAMP, ValueType::INT, 0, 'timestamp of last cron execution'), | ||
| new Entry(self::OCM_DISCOVERY_ENABLED, ValueType::BOOL, true, 'enable/disable OCM', lazy: true), | ||
| new Entry(self::OCM_INVITE_ACCEPT_DIALOG, ValueType::STRING, '', 'route to local invite accept dialog', lazy: true, note: 'set as empty string to disable feature'), |
There was a problem hiding this comment.
Why is that a setting, when is the route changing? How does the admin know the route?
There was a problem hiding this comment.
this should be done by an app
There was a problem hiding this comment.
In case it needs a change, please do a follow-up PR
There was a problem hiding this comment.
I do not think it’s usual to use a setting for inter-app communication, I do not recall other occurences of that in the code.
Which application would fill this value?
ArtificialOwl
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #55196