fix(settings): update all button only updates a single app #56469
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the chain of functions involved in the "update all apps" routine were not properly setup up with regards to asynchronism:
updateAll()were not awaited or managed properlyupdatefunction fed top-limit'slimit()utility was returning void and not a promise, as it expects (see docs)This was causing the mechanism driving the updates to potentially end prematurely.
This PR fixes this by:
async/awaitandPromises.allinupdateAll()to ensure all promises generated by p-limit are awaited and executed completely before the function finishes.update()return the promises it involvesThis would prevent the function from exiting prematurely and ensure all updates are processed automatically.
Checklist
3. to review, feature component)stable32)