Skip to content

Conversation

@mejo-
Copy link
Member

@mejo- mejo- commented Sep 30, 2025

Yjs pendingStructs mean that the local yjs document state is missing a step. So let's not allow to save such an inconstent state to the server.

Screenshot

Disabled save button
disabled_save

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo- mejo- self-assigned this Sep 30, 2025
@mejo- mejo- marked this pull request as draft September 30, 2025 15:57
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.55%. Comparing base (07cc286) to head (28ee3e7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7704      +/-   ##
==========================================
+ Coverage   59.52%   59.55%   +0.03%     
==========================================
  Files         503      503              
  Lines       39118    39150      +32     
  Branches     1130     1130              
==========================================
+ Hits        23285    23317      +32     
  Misses      15725    15725              
  Partials      108      108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo- mejo- force-pushed the fix/no_autosave_pending_structs branch from 19a67fe to d437604 Compare October 1, 2025 12:39
Yjs pendingStructs most likely mean that the local yjs document state
is missing a step. So let's not autosave such an inconstent state to the
server.

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- force-pushed the fix/no_autosave_pending_structs branch from d437604 to 28ee3e7 Compare October 1, 2025 13:32
@mejo- mejo- changed the title fix(SaveService): Don't autosave if yjs reports pendingStructs fix(SaveService): Don't save if yjs reports pendingStructs Oct 1, 2025
@max-nextcloud
Copy link
Collaborator

Waiting for the outcome of our attempts to prevent out of sync state and thus pending structs in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants