Skip to content

fix: improve handling of zip open and extraction errors #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve handling of zip open and extraction errors #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions setup-nextcloud.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,14 @@ static public function install() {

// unpacking into nextcloud folder
$zip = new ZipArchive;
$res = $zip->open('nc.zip');
if ($res==true) {
$zipState = $zip->open('nc.zip');
if ($zipState === true) {
// Extract it to the tmp dir
$nextcloud_tmp_dir = 'tmp-nextcloud'.time();
$zip->extractTo($nextcloud_tmp_dir);
$extraction = $zip->extractTo($nextcloud_tmp_dir);
if ($extraction === false) {
return 'Error during unpacking zipfile: ' . ($zip->getStatusString());
}
$zip->close();

// Move it to the folder
Expand All @@ -167,7 +170,7 @@ static public function install() {
// Delete the tmp folder
rmdir($nextcloud_tmp_dir);
} else {
$error.='unzip of nextcloud source file failed.<br />';
$error.='Unzip of nextcloud source file failed: ' . print_r($zipState, true) . ' <br />';
}

// deleting zip file
Expand Down