Modification from NF Language server #1779
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
main.nf
Outdated
| versions = versions.mix(PREPARE_INTERVALS.out.versions) | ||
|
|
||
| vep_fasta = (params.vep_include_fasta) ? fasta.map{ fasta -> [ [ id:fasta.baseName ], fasta ] } : [[id: 'null'], []] | ||
| vep_fasta = (params.vep_include_fasta) ? fasta.map{ fasta_ -> [ [ id:fasta_.baseName ], fasta_ ] } : [[id: 'null'], []] |
There was a problem hiding this comment.
why is the language server adding an underscore?
There was a problem hiding this comment.
because fasta is an already defined item, so we use _ after if the item is reused within the same scope or before is the item is dropped
There was a problem hiding this comment.
it hurts my eyes, but not going to argue with the language server
main.nf
Outdated
| versions = versions.mix(PREPARE_INTERVALS.out.versions) | ||
|
|
||
| vep_fasta = (params.vep_include_fasta) ? fasta.map{ fasta -> [ [ id:fasta.baseName ], fasta ] } : [[id: 'null'], []] | ||
| vep_fasta = (params.vep_include_fasta) ? fasta.map{ fasta_ -> [ [ id:fasta_.baseName ], fasta_ ] } : [[id: 'null'], []] |
There was a problem hiding this comment.
it hurts my eyes, but not going to argue with the language server
|
Can we get this merged? Or at least the syntax errors? The next release of the VS Code extension comes with a custom Pipeline view, which uses the language server to display a tree view of workflows and processes. Due to these syntax errors, the language server isn't able to parse several files and as a result the Pipeline view is incomplete. Fixing these syntax errors should allow the language server to provide the entire call tree. The variable name errors aren't essential for fixing the Pipeline view. But for what it's worth, you can rename those variables to whatever you want, it doesn't have to be |
|
Closed for #1912 |
5 participants
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).