Skip to content

Fix JS syntax issues #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix JS syntax issues #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions oauth2-token-introspection-plus/oauth2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* 204: token is active
* 403: token is not active
* 401: error condition (details written to error log at error level)
*
*
* Metadata contained within the token introspection JSON response is converted to response
* headers. These in turn are available to the auth_request location with the auth_request_set
* directive. Each member of the response is available to nginx as $sent_http_token_<member name>
Expand All @@ -26,7 +26,7 @@ function introspectAccessToken(r) {
var authHeader = "";
if (r.variables.oauth_client_id.length) {
var basicAuthPlaintext = r.variables.oauth_client_id + ":" + r.variables.oauth_client_secret;
authHeader = "Basic " + basicAuthPlaintext.toBytes().toString('base64');
authHeader = "Basic " + basicAuthPlaintext.toBytes().toString('base64');
} else {
authHeader = "Bearer " + r.variables.oauth_client_secret;
}
Expand All @@ -45,8 +45,8 @@ function introspectAccessToken(r) {
try {
r.log("OAuth token introspection response: " + reply.responseBody)
var response = JSON.parse(reply.responseBody); // Test for valid JSON so that we only store good responses
if (response.active.length) {
r.variables.token_data = response.toString('base64'); // Store this repsonse in keyval zone
if (response.active) {
r.variables.token_data = reply.responseBody.toBytes().toString('base64'); // Store this repsonse in keyval zone
tokenResult(r);
} else {
r.error("OAuth error in token introspection response: " + reply.responseBody);
Expand Down