-
Notifications
You must be signed in to change notification settings - Fork 28
Added instructions for firewalld #14
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CountPickering thanks for the PR!
I've added a few small suggestions, could you possibly implement them?
Additionally, because port 1936 is not used for regular traffic like ports 80 and 443, but rather the admin traffic, is it possible to extend the firewall-cmd
instruction to include the source range, similarly to the existing iptables command.
Co-Authored-By: CountPickering <[email protected]>
Co-Authored-By: CountPickering <[email protected]>
Co-Authored-By: CountPickering <[email protected]>
Co-Authored-By: CountPickering <[email protected]>
Co-Authored-By: CountPickering <[email protected]>
Co-Authored-By: CountPickering <[email protected]>
Your suggestions are on target and have been implemented. |
@CountPickering Thanks for implementing those suggestions!
regarding the comment above, can this be addressed? if there are no simple firewall-cmd commands for this case, then it makes sense to put a note right after the command. Something like below: Note: For simplicity, the firewall-cmd commands listed above do not configure the source IP range of the allowed traffic. It is recommended that you configure the source IP range to protect the [stub status page|dashboard] similarly to the iptables command. |
I would add the note as you suggested. With firewalld you can define a range but it requires the setup of a zone. The OpenShift 3.11 installer uses the public zone by default. |
@CountPickering that sounds good! thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CountPickering Thanks!
Could you possibly squash your commits into a single one? Once that is done, we'll merge the PR.
Just a note, this could be further expanded by demonstrating the command
|
Proposed changes
Added firewalld instructions on the installation pages. Also specified "infra nodes" in plural tense for the event multiple routers are run.
Checklist
Before creating a PR, run through this checklist and mark each as complete.