Skip to content

Conversation

@bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Oct 28, 2025

What does this Pull Request accomplish?

Enable system tests on Python 3.14

Update generator to sort annotation keys. Constructing a ConfigurationParameter message was implicitly sorting the annotation keys on Python 3.13 and earlier, but it started preserving order in Python 3.14, causing failures like this:

                12: ParameterMetadata(
                    display_name="Enum Array In",
                    type=Field.Kind.ValueType(14),
                    repeated=True,
                    default_value=[1, 2],
                    annotations={
  +                     "ni/enum.values": '{"NONE": 0, "RED": 1, "GREEN": 2, "BLUE": 3}',
                        "ni/type_specialization": "enum",
  -                     "ni/enum.values": '{"NONE": 0, "RED": 1, "GREEN": 2, "BLUE": 3}',
                    },
                    message_type="",
                    field_name="Enum_Array_In",
                    enum_type=EnumInEnum,
                ),

More info here: https://github.com/ni/measurement-plugin-python/pull/1258/files#r2467157116

Why should this Pull Request be merged?

Fix tests

What testing has been done?

Ran generator tests locally

@bkeryan bkeryan changed the title generator: Sort annotation keys in order to fix tests on Python 3.14 tests: Enable system tests on Python 3.14 and fix failing generator tests Oct 28, 2025
@bkeryan bkeryan mentioned this pull request Oct 28, 2025
1 task
@github-actions
Copy link
Contributor

Test Results

    60 files  +    4      60 suites  +4   1h 22m 26s ⏱️ + 5m 52s
   689 tests ±    0     689 ✅ ±    0      0 💤 ±0  0 ❌ ±0 
24 030 runs  +1 350  22 764 ✅ +1 348  1 266 💤 +2  0 ❌ ±0 

Results for commit 41c3b40. ± Comparison against base commit 8be7fa6.

@bkeryan bkeryan merged commit da0419f into main Oct 28, 2025
31 checks passed
@bkeryan bkeryan deleted the users/bkeryan/python-3.14-2 branch October 28, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants