Add documentation url and update intersphinx mappings #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Johansen <[email protected]>
Signed-off-by: Michael Johansen <[email protected]>
bkeryan
requested changes
Sep 11, 2025
There was a problem hiding this comment.
ni.measurementlink.discovery.v1.client/pyproject.toml is missing the doc url
Comment on lines
+79
to
+84
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.measurement.v1.proto": ("https://nimeasurementlinkmeasurementv1proto.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.measurement.v2.proto": ("https://nimeasurementlinkmeasurementv2proto.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.sessionmanagement.client": ("https://nimeasurementlinksessionmanagementclient.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.pinmap.v1.proto": ("https://nimeasurementlinkpinmapv1proto.readthedocs.io/en/latest/", None), |
There was a problem hiding this comment.
I don't think these are needed. Also, one is missing v1.
Suggested change
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.measurement.v1.proto": ("https://nimeasurementlinkmeasurementv1proto.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.measurement.v2.proto": ("https://nimeasurementlinkmeasurementv2proto.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.sessionmanagement.client": ("https://nimeasurementlinksessionmanagementclient.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.pinmap.v1.proto": ("https://nimeasurementlinkpinmapv1proto.readthedocs.io/en/latest/", None), | |
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | |
| ("https://nimeasurementlinksessionmanagementclient.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.pinmap.v1.proto": ("https://nimeasurementlinkpinmapv1proto.readthedocs.io/en/latest/", None), |
There was a problem hiding this comment.
ni.measurementlink.sessionmanagement.v1.client/pyproject.toml is missing the doc link
Comment on lines
80
to
87
| "grpc": ("https://grpc.github.io/grpc/python/", None), | ||
| "ni.measurementlink.sessionmanagement.v1.proto": ("https://nimeasurementlinksessionmanagementv1proto.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.pinmap.v1.proto": ("https://nimeasurementlinkpinmapv1proto.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.proto": ("https://nimeasurementlinkproto.readthedocs.io/en/latest/", None), | ||
| "ni.grpcdevice.v1.proto": ("https://nigrpcdevicev1proto.readthedocs.io/en/latest/", None), | ||
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | ||
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | ||
| } |
There was a problem hiding this comment.
Suggested change
| "grpc": ("https://grpc.github.io/grpc/python/", None), | |
| "ni.measurementlink.sessionmanagement.v1.proto": ("https://nimeasurementlinksessionmanagementv1proto.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.pinmap.v1.proto": ("https://nimeasurementlinkpinmapv1proto.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.proto": ("https://nimeasurementlinkproto.readthedocs.io/en/latest/", None), | |
| "ni.grpcdevice.v1.proto": ("https://nigrpcdevicev1proto.readthedocs.io/en/latest/", None), | |
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | |
| } | |
| "grpc": ("https://grpc.github.io/grpc/python/", None), | |
| "ni.measurementlink.sessionmanagement.v1.proto": ("https://nimeasurementlinksessionmanagementv1proto.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.proto": ("https://nimeasurementlinkproto.readthedocs.io/en/latest/", None), | |
| "ni.grpcdevice.v1.proto": ("https://nigrpcdevicev1proto.readthedocs.io/en/latest/", None), | |
| "ni-grpc-extensions": ("https://ni-grpc-extensions.readthedocs.io/en/latest/", None), | |
| "ni.measurementlink.discovery.v1.client": ("https://nimeasurementlinkdiscoveryv1client.readthedocs.io/en/latest/", None), | |
| } |
dixonjoel
reviewed
Sep 12, 2025
| @@ -31,6 +31,7 @@ requires-python = '>=3.9,<4.0' | |||
|
|
|||
| [project.urls] | |||
| repository = "https://github.com/ni/ni-apis-python" | |||
| documentation = "https://nidatamonikersv1proto.readthedocs.io/en/latest/" | |||
There was a problem hiding this comment.
This URL isn't responding for me.
https://nidatamonikersv1proto.readthedocs.io/en/latest/
There was a problem hiding this comment.
It's working now. @mjohanse-emr did you change anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
documentationinproject.urlsni-apis-python.Why should this Pull Request be merged?
Fixes #96
What testing has been done?
Docs build during PR checks