Skip to content

Conversation

rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented Sep 15, 2025

- [ ] I've updated CHANGELOG.md if applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

There are two APIs in which the return type is expected as a list of string, but we do return a comma separated string. This issue is fix in this PR for following APIs.

  • get_all_script_names
  • get_all_named_waveform_names

actual_buffer_size parameter is removed from APIs as this is not used in going forward approach.

Necessary documentation changes are done to point our list of strings as return type.

Also, the relevant system tests are included to verify the driver call.

What testing has been done?

The system tests are included to ensure that the driver call is happening as intended.
The Tox build success and modifies the generated files as expected.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.72%. Comparing base (4b9434f) to head (7f90b1a).
⚠️ Report is 1 commits behind head on master.

❌ Your project status has failed because the head coverage (81.72%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4b9434f) and HEAD (7f90b1a). Click for more details.

HEAD has 72 uploads less than BASE
Flag BASE (4b9434f) HEAD (7f90b1a)
codegenunittests 3 1
nifakeunittests 15 5
nidcpowerunittests 15 5
nidigitalunittests 15 5
nimodinstunittests 15 5
niscopeunittests 15 5
nitclkunittests 15 5
nimodinstsystemtests 1 0
nisesystemtests 1 0
nirfsgsystemtests 1 0
niswitchsystemtests 1 0
nifgensystemtests 1 0
nidmmsystemtests 1 0
niscopesystemtests 1 0
nidcpowersystemtests 1 0
nitclksystemtests 1 0
nidigitalsystemtests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2133      +/-   ##
==========================================
- Coverage   89.07%   81.72%   -7.36%     
==========================================
  Files          71       29      -42     
  Lines       18960     4115   -14845     
==========================================
- Hits        16889     3363   -13526     
+ Misses       2071      752    -1319     
Flag Coverage Δ
codegenunittests 84.44% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests ?
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests ?
nimodinstsystemtests ?
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests ?
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests ?
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9434f...7f90b1a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI changed the title Fix: get_all_script_names API to return list of strings than a comma separated string Fix: get_all_script_names and get_all_named_waveform_names APIs to return list of strings than a comma separated string Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants