Skip to content

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Sep 15, 2025

Changes proposed in this pull request

Transfer developers.json contents to Markdown files. Specificaly:

  • Transfer all contributors to CONTRIBUTORS.md by default.
  • Remove Ted Satterthwaite from CONTRIBUTORS.md as he is listed in PIs.md
  • Do not add names for those individuals who are listed in PIs.md (Oscar Esteban, Russ Poldrack) or MAINTAINERRS.md (Chris Markiewicz, Mathias Goncalves).
  • Take advantage of the commit to sort alphabetically Gomez and Groen.

Documentation that should be reviewed

N/A

Fixes #3514.

Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (04ef0cf) to head (13beda7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3523   +/-   ##
=======================================
  Coverage   73.64%   73.64%           
=======================================
  Files          60       60           
  Lines        4759     4759           
  Branches      616      616           
=======================================
  Hits         3505     3505           
  Misses       1111     1111           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Transfer `developers.json` contents to Markdown files. Specificaly:
- Transfer all contributors to `CONTRIBUTORS.md` by default.
- Remove Ted Satterthwaite from `CONTRIBUTORS.md` as he is listed in
  `PIs.md`
- Do not add names for those individuals who are listed in `PIs.md`
  (Oscar Esteban, Russ Poldrack) or `MAINTAINERRS.md` (Chris Markiewicz,
  Mathias Goncalves).
- Take advantage of the commit to sort alphabetically Gomez and Groen.
@jhlegarreta jhlegarreta force-pushed the mnt/transition-contrib-to-md branch from 85473fa to 13beda7 Compare September 15, 2025 23:54
@effigies
Copy link
Member

Scripts need updating, if this is to be removed.

󰅂 git grep developers.json
.maint/paper_author_list.py:    devs = json.loads(Path('.maint/developers.json').read_text())
.maint/update_zenodo.py:    creators = json.loads(Path('.maint/developers.json').read_text())

@effigies effigies marked this pull request as draft September 16, 2025 12:25
@effigies
Copy link
Member

Marking as draft to make quickly reviewing the PR list simpler. Please do not hesitate to mark ready for review when you think it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.maint/developers.json file is deprecated
2 participants