-
-
Notifications
You must be signed in to change notification settings - Fork 179
flake: disable CI for packages #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4b822d
to
638bfe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing all elisp packages from CI is a bit unfortunate. However, I support this decision since it causes trouble for the infra team.
If there are specific packages that would benefit from being built and cached they can be added back to hydraJobs
Currently we use CI results to find broken builds when bumping all elisp packages in Nixpkgs. Here is an example. We can build all elisp packages locally to find broken builds after this PR.
I would like another maintainer of this repo to take a look before I merge this.
I didn't know that it was used for this. Does this involve the stable and unstable sets from this repo or just unstable? I wouldn't mind running a eval manually once every couple of weeks of reduced jobset, e.g. only unstable on x86_64-linux. |
Only
That would be great! Currently we do those bumps each time a staging-next cycle starts. So yeah, once every couple of weeks. Building all elisp packages locally would take about 30 minutes. However, building them in CI would give reviewers of those bumps some useful links. |
What about these emacs variants, is it fine to only build them every couple of weeks or would you want to keep building them continuously? Lines 73 to 81 in 045f679
|
We want to keep building emacs variants continuously. There are known users of some of them and only 5 of them change frequently. |
638bfe6
to
34d9262
Compare
We can't do both in the same flake on hydra, currently it hardcodes Would need to separate the variants and the packages into different attributes and either make the hardcoded attributes configurable in hydra or move the emacs variants to a different CI (buildbot supports a scheduled build without PR checks, similar to hydra but it can use a different attribute). |
Thanks for the info. Building Emacs variants on buildbot and elisp packages on hydra (with manual triggers) sound great!. I am not familiar with CI settings for both hydra and buildbot. I can allocate some time to figure this out in 1 or 2 weeks. I notice that currently hydra only build Emacs variants so I guess this is not urgent. Please correct me if I am wrong. |
Separate attributes and buildbot/hydra changes isn't urgent but currently hydra is building this branch so will need to keep rebasing the PR until it is merged. I've opened #512 for the separating the attributes for buildbot but I'll look at making hydra configurable in the next few days, I don't think it'll be too complicated to resolved. |
a8d10a8
to
80d8020
Compare
80d8020
to
d2fb486
Compare
@jian-lin Can you merge this please? |
@zowoq Sure. What is the path forward after this PR? |
Let me know when you want to bump the nixpkgs elisp packages and I'll apply the hydra patch and trigger an eval of #512. |
@zowoq Here is the last bump NixOS/nixpkgs#435408. I think we will do another bump in a week or two. |
@adisbladis @jian-lin
Unfortunately the size of the jobset and types of builds has been a problem, thousands of small, cheap builds is basically the opposite of all of the other hydra jobs.
If there are specific packages that would benefit from being built and cached they can be added back to hydraJobs, even a few hundred would be fine, just not thousands.