vscode: get paths from product.json #7866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for picking this up. |
Contributor
Author
|
I switched to a hybrid approach to avoid IFD - now it will use preset names for products that are known ahead of time, and otherwise fall back to IFD if it's not known. |
andre4ik3
force-pushed
the
product
branch
2 times, most recently
from
5357528 to
ed5d39f
Compare
Contributor
Author
|
Also updated the tests. It will run the tests once with a known |
The VSCode packages contain a product.json which is used to determine the extension and config dirs. When the package name is not known, this change parses this file (using IFD) (which may appear in a few places) and uses that to generate the paths. This hopefully allows more VSCode derivatives to "just work" without Home Manager updates. Co-authored-by: andre4ik3 <[email protected]>
Member
|
Thanks! Merged to master now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated version of #5948 with added support for Darwin. Also reformatted some
commit messages. (I preserved the commit history, let me know if I should
squash everything into 1-2 commits)
Closes #5948
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.