Skip to content

plugins/roslyn: init #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

plugins/roslyn: init #3166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions plugins/by-name/roslyn/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{ lib, pkgs, ... }:
lib.nixvim.plugins.mkNeovimPlugin {
name = "roslyn";
packPathName = "roslyn.nvim";
package = "roslyn-nvim";

maintainers = [ lib.maintainers.GaetanLepage ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not adding yourself as the maintainer?


extraConfig = {
plugins.roslyn.settings.exe = lib.mkDefault "Microsoft.CodeAnalysis.LanguageServer";
};

# TODO: Figure out how to add this package, as it's the source of the `Microsoft.CodeAnalysis.LanguageServer` command, which is required for the LSP to function
# home.packages = [ pkgs.roslyn-ls ];
Comment on lines +13 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unfamiliar with this LS, so I don't know if it is better to contribute to nvim-lspconfig (so that our plugins.lsp.servers options can be used) or to assume all configuration will be done by this plugin separately from nvim-lspconfig.

If the LS can't really be configured by nvim-lspconfig, the next best thing would be to use our new dependencies options.

To do this, you would edit modules/dependencies.nix, and add "roslyn-ls" to the list. Then you would edit extraConfig here, and define dependencies.roslyn-ls.enable = lib.mkDefault true.

}
5 changes: 5 additions & 0 deletions tests/test-sources/plugins/by-name/roslyn/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
empty = {
plugins.roslyn.enable = true;
};
}