-
-
Notifications
You must be signed in to change notification settings - Fork 348
plugins/perfanno: add perfanno-nvim plugin #3653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/perfanno: add perfanno-nvim plugin #3653
Conversation
f1a79c0
to
7355b55
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
7355b55
to
29544e5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
29544e5
to
6a526f4
Compare
I rebased on |
plugins/by-name/perfanno/default.nix
Outdated
# TODO: Remove after https://github.com/NixOS/nixpkgs/pull/438707 | ||
url = "https://github.com/t-troebst/perfanno.nvim"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NixOS/nixpkgs#438707 is in all unstable channels now, and should be part of the revision we've updated to.
It should be safe to remove the explicit URL now:
# TODO: Remove after https://github.com/NixOS/nixpkgs/pull/438707 | |
url = "https://github.com/t-troebst/perfanno.nvim"; |
Note to self: should we throw when url
is explicitly defined the same as the package's meta.homepage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that an assertion would be great. I almost feel like a build should assert if both define a url, regardless of the value, because and then assume the upstream is always correct
6a526f4
to
d8b0ce3
Compare
@MattSturgeon I added the explicit require. Do you still think I should use |
Oh wow, yes that looks awful 😅
I'll fix it up
…On 10 September 2025 19.51.27 CEST, Matt Sturgeon ***@***.***> wrote:
MattSturgeon left a comment (nix-community/nixvim#3653)
Testing locally with `nix run .#docs`:
<img width="981" height="1183" alt="image" src="https://github.com/user-attachments/assets/316beb07-fd28-4a45-ae51-34b1ac2c7bc6" />
Personally, I'd prefer using `literalExpression` or `nestedLiteralLua`, but this isn't a blocker.
--
Reply to this email directly or view it on GitHub:
#3653 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
d8b0ce3
to
cd8386c
Compare
plugins/by-name/perfanno/default.nix
Outdated
maintainers = [ lib.maintainers.fredeb ]; | ||
|
||
settingsExample = { | ||
line_highlights = lib.nixvim.literalLua ''require("perfanno.util").make_bg_highlights(nil, "#CC3300", 10)''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, using the wrong one doesn't cause a CI failure, but I believe we need nestedLiteralLua
here instead of literalLua
.
You may also wish to switch to using single quotes in your lua, as I don't think it is smart enough to render a ''
string instead of "
, unless the string includes newlines.
Or if you want full control, you can render the entire example yourself manually using a literalExpression
.
You can confirm how it renders locally, using nix run .#docs
(which may be a long build on the initial run).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. I did kick off the docs build, but it's still going, so I'm still waiting for the result. I'm at 7650/8389 now, so I'll wait for it to finish and validate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a shame our docs take so long. I've put effort in the past into re-implementing the docs more efficiently, but sadly none of those efforts ever made it over the line.
cd8386c
to
57210cb
Compare
@MattSturgeon take 92, how we doin? 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your persistence and attention to detail!
Adds https://github.com/t-troebst/perfanno.nvim
perfanno-nvim was just recently added to nixpkgs, so cannot be merged until flake.lock is updated
see NixOS/nixpkgs#436798