plugins/harpoon: fix pack path name #3676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy loading needs the correct name for finding the plugin in `opt`. With change to `harpoon2` as the default, we need to fix the `packPathName` to match.
Kinda off topic, but is there a way we can cover lazy loading in our test suite? Or at least a way to verify names are correct? |
MattSturgeon
approved these changes
Sep 10, 2025
Would be nice to have something setup to verify. I think last time I talked about it, we could default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy loading needs the correct name for finding the plugin in
opt. With change toharpoon2as the default, we need to fix thepackPathNameto match.