userborn: enable by default

[Mic92]

I have tested this for a wile without any issues.
If it works find in srvos, we can propose this to nixos itself.

[zowoq]

Causes nixos-rebuild switch / nixos-rebuild-switch-to-configuration.service to fail?

I tried it on build01:

switch fails.

boot works but then running switch again (switching into the current booted generation) fails?

[Mic92]

What is the failure? We should probably report issues like this.

[zowoq]

Dec 05 00:42:37 build01 systemd[1]: Starting /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3/bin/switch-to-configuration switch...
Dec 05 00:42:37 build01 systemd[1]: Started /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3/bin/switch-to-configuration switch.
Dec 05 00:42:38 build01 nixos[4248]: switching to system configuration /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3
Dec 05 00:42:40 build01 nixos[4248]: switching to system configuration /nix/store/k88rz3p58mp584jd0v63wlxx3vja2fwg-nixos-system-build01-25.05.20241201.767b0e3 failed (status 2)
Dec 05 00:42:40 build01 systemd[1]: nixos-rebuild-switch-to-configuration.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Dec 05 00:42:40 build01 systemd[1]: nixos-rebuild-switch-to-configuration.service: Failed with result 'exit-code'.

[Mic92]

@zowoq are you sure this is caused by userborn?

[zowoq]

Yes.

[Mic92]

The error message doesn't give anything away. I would have expected all userborn runs to also have an error message.

[Mic92]

The only exit code here is 1: https://github.com/nikstur/userborn/blob/2c4dca6cac5e974727e2b6b22bab2fd2ebe991f3/rust/userborn/src/main.rs#L55
And it should always print an error. The activation script exits with 2 however.

[zowoq]

I tried enabling it on a personal system and build04, same error on both.

[Mic92]

Ok. This is reason enough to not enable it by default for now.

[Mic92]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The pull request #575 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[Mic92]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

• ❌ buildbot/nix-build

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

[SuperSandro2000]

For my config this just worked but it still feels a bit "alpha" or at least beta

[Mic92]

For my config this just worked but it still feels a bit "alpha" or at least beta

How so? I am using this since September without any issues?

[SuperSandro2000]

Found a small issue nikstur/userborn#14 but maybe I just forget about it in the next weeks and it really just works.

[phaer]

I believe this should be good to merge? Or are there any objections left?

[zowoq]

Do we want to wait for the userborn fixes to land in nixpkgs?

[SuperSandro2000]

We want to merge the linked PR in nikstur/userborn#13 (comment) and do something about nikstur/userborn#7 (comment) and then push for a release. I've been using this for a while with no extra problems.

[Mic92]

We want to merge the linked PR in nikstur/userborn#13 (comment) and do something about nikstur/userborn#7 (comment) and then push for a release. I've been using this for a while with no extra problems.

We already not enable userborn for agenix, so this just subuids are not addressed.

[nikstur]

Since nikstur/userborn#13 is merged, can you enable Userborn by default now? Or do you need the subuids feature to do that?

[aanderse]

was there any resolution to the subuid stuff? i am not saying it's the responsibility of userborn but since the option exists and does nothing it seems like something needs to happen here... no?

[nikstur]

Yes I agree and understand that something needs to be done to fix the SUBUIDs/SUBGIDs issue and I see this within the responsibility of Userborn. I just want to understand whether this is needed for srvos, i.e. whether this is a blocker.

[aanderse]

fwiw userborn rocks and has been nothing but great for me... thanks again ❤️

[Mic92]

Yes I agree and understand that something needs to be done to fix the SUBUIDs/SUBGIDs issue and I see this within the responsibility of Userborn. I just want to understand whether this is needed for srvos, i.e. whether this is a blocker.

I think we just need to not enable userborn if any of the options that userborn doesn't support is enabled.