Skip to content

Conversation

trueNAHO
Copy link
Member

Fixes: b4e1daad3bcd ("ci: request subsystem maintainers review (#1053)")

Implementation of the #1053 (comment) proposal. This is an alternative fix to #1846.


Submission Checklist

Notify Maintainers

@awwpotato, @danth

Fixes: b4e1daa ("ci: request subsystem maintainers review (nix-community#1053)")
@trueNAHO trueNAHO added the backport: release-25.05 Changes to release-25.05 stable branch label Aug 18, 2025
@stylix-automation stylix-automation bot added the topic: ci /.github/ subsystem label Aug 18, 2025
@trueNAHO
Copy link
Member Author

Let's just merge this and hope for the best.

@trueNAHO trueNAHO merged commit 9810b32 into nix-community:master Aug 18, 2025
7 checks passed
Copy link
Contributor

Successfully created backport PR for release-25.05:

stylix-automation bot pushed a commit that referenced this pull request Aug 18, 2025
Fixes: b4e1daa ("ci: request subsystem maintainers review (#1053)")
Link: #1848

Reviewed-by: Daniel Thwaites <[email protected]>
(cherry picked from commit 9810b32)
@github-actions github-actions bot added the has: port to stable This has been backported to the latest stable branch label Aug 18, 2025
@trueNAHO
Copy link
Member Author

trueNAHO commented Aug 18, 2025

Let's just merge this and hope for the best.

First successful run at https://github.com/nix-community/stylix/actions/runs/17050785328/job/48337632903?pr=1794. Since the reviewer has already been requested, this does not very whether new reviewers are properly added.

@awwpotato
Copy link
Contributor

Since the reviewer has already been requested, this does not very whether new reviewers are properly added.

it does add new reviewers correctly #1794 (comment) 🎉

trueNAHO added a commit that referenced this pull request Aug 18, 2025
Fixes: b4e1daa ("ci: request subsystem maintainers review (#1053)")
Link: #1848

Reviewed-by: Daniel Thwaites <[email protected]>
(cherry picked from commit 9810b32)
make-42 pushed a commit to make-42/stylix that referenced this pull request Sep 13, 2025
Fixes: b4e1daa ("ci: request subsystem maintainers review (nix-community#1053)")
Link: nix-community#1848

Reviewed-by: Daniel Thwaites <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: release-25.05 Changes to release-25.05 stable branch has: port to stable This has been backported to the latest stable branch topic: ci /.github/ subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants