ci: request-reviewers: exclude automated backports #1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is untested, fragile, and subject to false positives. The current implementation is to start a conversation about whether this functionality is desirable.
The current
!startsWith(github.event.pull_request.head.ref, 'backport-')
guard is fragile because it does not check for the more restrictivebackport-<HASH>-to-release-25.05
pattern. It is subject to false positives because manual backports might desirably follow thebackport-<HASH>-to-release-25.05
naming convention, and manual backports may arbitrarily diverge from their original commits.From a quick search, GitHub does not seem to provide a function to trivially match on the
backport-<HASH>-to-release-25.05
pattern, although the following might do the job:Should manual backports request review by default?
The fragile
backport-<HASH>-to-release-25.05
pattern matching could be replaced with a more sophisticated implementation where the "Backport" Action shares state with the "Request Reviewers" Action, possibly by having "Backport" add a custom dedicated label to its PRs, which "Request Reviewers" uses as guard.Submission Checklist
Notify Maintainers
@awwpotato @danth